update expected trap message in passing-resources.wast#599
Merged
lukewagner merged 1 commit intoWebAssembly:mainfrom Jan 20, 2026
Merged
update expected trap message in passing-resources.wast#599lukewagner merged 1 commit intoWebAssembly:mainfrom
passing-resources.wast#599lukewagner merged 1 commit intoWebAssembly:mainfrom
Conversation
I'm preparing a Wasmtime PR which ensures that a thread and task is allocated every time a component is entered, regardless of whether the export is sync or async typed, sync or async lifted. Consequently, we get a slightly different trap in `passing-resources.wast` such that the passed handle is valid but not of the correct kind (i.e. it's a thread handle rather than a resource handle).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm preparing a Wasmtime PR which ensures that a thread and task is allocated every time a component is entered, regardless of whether the export is sync or async typed, sync or async lifted. Consequently, we get a slightly different trap in
passing-resources.wastsuch that the passed handle is valid but not of the correct kind (i.e. it's a thread handle rather than a resource handle).